Skip to content

CLN: assorted #52820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2023
Merged

CLN: assorted #52820

merged 2 commits into from
Apr 21, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@@ -22,7 +22,7 @@ from numpy cimport (

cnp.import_array()

from cpython.datetime cimport ( # alias bc `tzinfo` is a kwarg below
from cpython.datetime cimport ( # alias tzinfo_type bc `tzinfo` is a kwarg below
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm i had tried to put this comment adjacent to the tzinfo_type import but looks like one of the hooks moved it back

@mroeschke mroeschke added this to the 2.1 milestone Apr 21, 2023
@mroeschke mroeschke added Clean Typing type annotations, mypy/pyright type checking labels Apr 21, 2023
@mroeschke mroeschke merged commit f94bdc4 into pandas-dev:main Apr 21, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the fixmes73 branch April 21, 2023 17:25
Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
* CLN: assorted

* typo fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants